Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: return str from contracts #1159

Merged
merged 3 commits into from
Oct 10, 2023
Merged

feat: return str from contracts #1159

merged 3 commits into from
Oct 10, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Oct 9, 2023

This PR adds support for str returned from contract calls (either directly, or inside enums)

Full support will be added once sway is ready. Issue to track: #1158

Checklist

  • I have linked to any relevant issues.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Oct 9, 2023
@hal3e hal3e self-assigned this Oct 9, 2023
@digorithm digorithm added blocked and removed blocked labels Oct 10, 2023
@hal3e hal3e merged commit 7a94e0b into master Oct 10, 2023
38 checks passed
@hal3e hal3e deleted the hal3e/string-slices branch October 10, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@segfault-magnet segfault-magnet segfault-magnet approved these changes

@MujkicA MujkicA MujkicA approved these changes

@Salka1988 Salka1988 Salka1988 approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@iqdecay iqdecay Awaiting requested review from iqdecay

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@hal3e @Br1ght0ne @Salka1988 @MujkicA @segfault-magnet @digorithm