Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use TxStatus to map revert errors #1142

Merged
merged 6 commits into from
Oct 4, 2023
Merged

refactor: use TxStatus to map revert errors #1142

merged 6 commits into from
Oct 4, 2023

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Sep 27, 2023

While working on an other issue, I have seen that we have some duplicated code for revert error mapping. I have refactored the code a bit so that we can remove the map_revert_error function and use the logic inside TxStatus

Checklist

  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@hal3e hal3e added the tech-debt Improves code quality or safety label Sep 27, 2023
@hal3e hal3e self-assigned this Sep 27, 2023
digorithm
digorithm approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

iqdecay
iqdecay approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@iqdecay iqdecay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice find

@hal3e hal3e merged commit 17247fc into master Oct 4, 2023
37 checks passed
@hal3e hal3e deleted the refactor/remove-map-error-in-call-handlers branch October 4, 2023 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iqdecay iqdecay iqdecay approved these changes

@Br1ght0ne Br1ght0ne Br1ght0ne approved these changes

@digorithm digorithm digorithm approved these changes

@MujkicA MujkicA Awaiting requested review from MujkicA MujkicA is a code owner

@segfault-magnet segfault-magnet Awaiting requested review from segfault-magnet segfault-magnet is a code owner

@Salka1988 Salka1988 Awaiting requested review from Salka1988 Salka1988 is a code owner

Assignees

@hal3e hal3e

Labels
tech-debt Improves code quality or safety
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hal3e @digorithm @Br1ght0ne @iqdecay