Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): remove unused deps, add corresponding CI check #1140

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

Br1ght0ne
Copy link
Contributor

No relevant issue - just tech debt.

Removes dependencies unused by our crates, and adds a step to ci.yml to report them in the future.

This is accomplished with cargo-machete, which reported only a single false positive - a crate called Inflector (titlecase), but used in code as inflector (lowercase); I added a corresponding exception.

Checklist

  • I have linked to any relevant issues.
  • I have updated the documentation.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary labels.
  • I have done my best to ensure that my PR adheres to the Fuel Labs Code Review Standards.
  • I have requested a review from the relevant team or maintainers.

@Br1ght0ne Br1ght0ne added tech-debt Improves code quality or safety P2 Low priority labels Sep 26, 2023
@Br1ght0ne Br1ght0ne self-assigned this Sep 26, 2023
Copy link
Contributor

@MujkicA MujkicA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@digorithm digorithm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, it's always great to remove dependencies. Nice initiative!

Copy link
Member

@Salka1988 Salka1988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Br1ght0ne Br1ght0ne merged commit 39bd29f into master Sep 27, 2023
37 checks passed
@Br1ght0ne Br1ght0ne deleted the oleksii/remove-unused-deps branch September 27, 2023 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 Low priority tech-debt Improves code quality or safety
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants