-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return Enums containing heap types at depth 1 #1106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
requested review from
digorithm,
hal3e,
MujkicA,
segfault-magnet,
Salka1988 and
Br1ght0ne
as code owners
August 28, 2023 13:10
iqdecay
force-pushed
the
iqdecay/feat-wrapped-bytes-output
branch
from
August 30, 2023 13:41
6637200
to
575da0d
Compare
iqdecay
force-pushed
the
iqdecay/feat-wrapped-bytes-output
branch
from
September 14, 2023 13:04
5150518
to
ba5955c
Compare
Co-authored-by: Ahmed Sagdati <[email protected]>
Co-authored-by: Ahmed Sagdati <[email protected]>
MujkicA
reviewed
Oct 4, 2023
MujkicA
previously approved these changes
Oct 4, 2023
segfault-magnet
previously approved these changes
Oct 4, 2023
segfault-magnet
approved these changes
Oct 4, 2023
hal3e
approved these changes
Oct 4, 2023
Br1ght0ne
approved these changes
Oct 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables returning heap types surrounded in an
Enum
type. It notably enables returninga
Result<Vec>
for instance from a contract call.Closes #940.
Main disavantages from this approach: