Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make necessary refactoring to enable no_std support #62

Closed
digorithm opened this issue Jan 25, 2022 · 7 comments
Closed

Make necessary refactoring to enable no_std support #62

digorithm opened this issue Jan 25, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@digorithm
Copy link
Member

Due to many issues with the current way we were enabling no_std support on fuels-rs, we had to revert and remove no_std support for now. Previous versions will still work normally.

However, we still want to enable no_std to some parts of fuels-rs that are needed as no_std, such as the Fuel's indexer. This will require some major refactoring/reorganization in order to make it more no_std friendly.

Some parts that need to be included as no_std:

  1. The code that gets emitted from wasm_abigen;
  2. ABIDecoder;
  3. Token, Tokenizable, ParamType, and related dependencies.
@digorithm digorithm self-assigned this Jan 25, 2022
@digorithm digorithm added the enhancement New feature or request label Jan 25, 2022
@digorithm digorithm moved this to Todo in Fuel Network Jan 25, 2022
@digorithm digorithm moved this from Todo to In Progress in Fuel Network Jan 25, 2022
@digorithm digorithm moved this from In Progress to Todo in Fuel Network Jan 26, 2022
@mitchmindtree mitchmindtree self-assigned this Feb 10, 2022
@adlerjohn
Copy link
Contributor

@mitchmindtree are you still planning on working on this?

@mitchmindtree
Copy link
Contributor

Ahh apologies, I intended to look into it as a way to get started but have been consumed by forc stuff :) I'll unassign myself in case anyone else would like to take this on!

@mitchmindtree mitchmindtree removed their assignment Mar 22, 2022
@adlerjohn
Copy link
Contributor

@digorithm are you still planning on working on this? 😂

@digorithm
Copy link
Member Author

To be honest, only if/when it's actually needed. There are so many more higher priority items that this one is way lower in priority. Of course its priority would change if it becomes a blocker to someone.

Since we removed no_std support I haven't heard any requests for it, so I'm assuming it's not needed at the moment.

@Voxelot
Copy link
Member

Voxelot commented Mar 22, 2022

It's causing circular dependency issues between fuel-core and fuel-indexer, and fuel-indexer is stuck on an outdated version of fuels-rs (v0.2) until this is resolved. We can potentially get someone from the client team to look into this if you don't have bandwidth.

@mitchmindtree
Copy link
Contributor

mitchmindtree commented May 24, 2022

Closing this in favour of #317 as we've discovered fuel-indexer doesn't need #![no_std], but rather needs the ability to compile to the wasm target. It's a similar problem, but hopefully quite a bit easier to address. Edit: Actually after a closer look #317 doesn't really cover this - I'll open a dedicated issue.

@mitchmindtree
Copy link
Contributor

I've opened #318.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

4 participants