-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore!: remove unused
response
method (#1263)
The `response` method from `ScriptCallHandler`, `ContractCallHandler` and `MultiContractCallHandler` was unreachable because of: ```rust let tx_id = self.cached_tx_id.expect("Cached tx_id is missing"); ``` Which means that if there is no cached `tx_id` this method will panic. The only way to get a `tx_id` is by calling `call`, `simulate` or `submit` and these methods return other types that handle the response. Even though this method was never used, I will mark the PR as breaking as the method was `pub`. BREAKING CHANGE: remove `response` method from `ScriptCallHandler`, `ContractCallHandler` and `MultiContractCallHandler`.
- Loading branch information
Showing
2 changed files
with
2 additions
and
41 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters