cleanup for add zk opcodes PR #874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dentosal
requested review from
xgreenx,
MitchTurner and
Voxelot
as code owners
AurelienFT
reviewed
Nov 28, 2024
|
I will check to fix it. |
|
The coordinates reading was inverted for a point. |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 29, 2024
* Add boilerplate new opcodes * Format * Update changelog * Add more boilerplate * Add code for ec add and ec mul * Update reserved_registers * Add source code pairing * use alloc vec * Add gas costs charge * Add tests for new zk opcodes * remove forget dbg * Add more test case for zk opcodes * Remove old todo * Fix clippy in tests * Change elliptic curve point error variant * Change gas costs to v5 because v4 is already released * format * Update ec pairing to ouput directly in the register and fix the test * Update comments on opcodes * Update zk opcode to match the new spec * Update EPAR prototype * update gas costs functions * Update default gas ecop based on benches * Add tests with instructions * Change gas epar * Fomat * Update fuel-vm/src/interpreter/crypto.rs Co-authored-by: Hannes Karppila <[email protected]> * cleanup for add zk opcodes PR (#874) * Simplify error types * Use MemoryOverflow instead of ArithmeticOverflow * Fix inversion letter --------- Co-authored-by: AurelienFT <[email protected]> * Add some doc about the usage of operation symbols + and * * Add memory overflow tests * fix clippy --------- Co-authored-by: Hannes Karppila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemoryOverflowinstead ofArithmeticOverflowfor memory ptr overflowsFrom<PanicReason>impl ofPanicOrBugto simplify code