Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

docs: link to docs hub fuel installation guide #1374

Merged
merged 4 commits into from
Oct 16, 2023

Conversation

cold-briu
Copy link
Contributor

In order to remove documentation redundancy issues, the fuel installation guide is being centralized in the docs-hub.
Check docs-hub/62

@deekerno
Copy link
Contributor

Setting this to draft as it appears that the requisite PR for the docs hub has not been merged.

@cold-briu cold-briu marked this pull request as ready for review October 5, 2023 22:52
@cold-briu
Copy link
Contributor Author

Installation guide was merged 🫡

Copy link
Contributor

@ra0x3 ra0x3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cold-briu One comment from me. Will defer to @deekerno and @lostman as well


Install `fuelup` by running the following command, which downloads and runs the installation script.

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cold-briu

  • Any reason we removed this?
  • If possible, it'd be preferable to keep the user on this page (no extra clicks) if installing fuelup is still possible in a single command.
    • Similarly for the "After fuelup has been installed," bit below. Are we throwing the baby 👶🏼 out with the bath water 🛀🏼 here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To extend @ra0x3's point, the intention was to (when possible) prevent the user from having to go to another page just to come back to this one after they install fuelup. I think there's a middle ground where we include the link but also include the one-line installation command; that way, they can open it if they want more information.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there! Thanks for reviewing.

  • The main reason for this is to reduce content duplication across the entire toolchain documentation, simplifying maintenance.

  • I understand your perspective on keeping the user in the same page.

  • My take is to use mdbook code imports as seen here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

In the short term, we won't take further action here since it is common that the user already have the toolchain installed by the moment they start working with the indexer.

I'll request review again, so it can be merged.

docs/src/getting-started/dependencies.md Outdated Show resolved Hide resolved
@cold-briu cold-briu requested a review from deekerno October 10, 2023 16:05
@cold-briu cold-briu requested a review from ra0x3 October 12, 2023 04:39
@ra0x3 ra0x3 merged commit 1869504 into develop Oct 16, 2023
18 checks passed
@ra0x3 ra0x3 deleted the docs/fuelup-install-guide branch October 16, 2023 13:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants