-
Notifications
You must be signed in to change notification settings - Fork 5
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be tested in CI?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of nits
Related: FuelLabs/fuels-rs#351 |
@Br1ght0ne Seems like this PR is g2g once the alloc feature is configured correctly. cc @digorithm |
Yup, it's looking good to me (other than the alloc feat config). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional nit about CI.
Regarding the toml file, I'd like to keep it as simple as possible. If we insert logic there, things might get more convoluted than they should be
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge conflicts!
is this one ready for re-review @Br1ght0ne?
It is in fact ready @adlerjohn! |
Next step is to edit the code and include the signature primitives as part of the |
I'll do this ASAP in a separate PR. |
No description provided.