Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

feat: support wasm32 target #26

Merged
merged 6 commits into from
Aug 26, 2022
Merged

feat: support wasm32 target #26

merged 6 commits into from
Aug 26, 2022

Conversation

Br1ght0ne
Copy link
Contributor

No description provided.

@Br1ght0ne Br1ght0ne self-assigned this May 28, 2022
@Br1ght0ne Br1ght0ne marked this pull request as draft May 28, 2022 20:25
@Br1ght0ne Br1ght0ne marked this pull request as ready for review May 28, 2022 20:28
@adlerjohn adlerjohn requested review from vlopes11 and Voxelot May 29, 2022 19:09
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be tested in CI?

Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits

Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@Br1ght0ne
Copy link
Contributor Author

Related: FuelLabs/fuels-rs#351

@Voxelot Voxelot requested a review from rakita June 13, 2022 17:46
@Voxelot
Copy link
Member

Voxelot commented Jun 20, 2022

@Br1ght0ne Seems like this PR is g2g once the alloc feature is configured correctly.

cc @digorithm

@digorithm
Copy link
Member

Yup, it's looking good to me (other than the alloc feat config).

@Br1ght0ne Br1ght0ne requested a review from vlopes11 June 27, 2022 08:54
Copy link
Contributor

@vlopes11 vlopes11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional nit about CI.

Regarding the toml file, I'd like to keep it as simple as possible. If we insert logic there, things might get more convoluted than they should be

.github/workflows/ci.yml Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts!

is this one ready for re-review @Br1ght0ne?

@adlerjohn adlerjohn removed the request for review from rakita August 5, 2022 01:29
@Br1ght0ne Br1ght0ne marked this pull request as draft August 8, 2022 10:24
@Br1ght0ne Br1ght0ne marked this pull request as ready for review August 8, 2022 10:28
@Br1ght0ne
Copy link
Contributor Author

It is in fact ready @adlerjohn!

@adlerjohn adlerjohn requested a review from vlopes11 August 8, 2022 14:34
@vlopes11
Copy link
Contributor

Next step is to edit the code and include the signature primitives as part of the no-std package

@Br1ght0ne Br1ght0ne merged commit d94039b into master Aug 26, 2022
@Br1ght0ne Br1ght0ne deleted the oleksii/wasm branch August 26, 2022 16:15
@Br1ght0ne
Copy link
Contributor Author

Next step is to edit the code and include the signature primitives as part of the no-std package

I'll do this ASAP in a separate PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

6 participants