Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: add assert_ne and revert_with_log revert signals #27

Merged
merged 1 commit into from
Dec 2, 2024
Merged

feat!: add assert_ne and revert_with_log revert signals #27

merged 1 commit into from
Dec 2, 2024

Conversation

hal3e
Copy link
Contributor

@hal3e hal3e commented Nov 25, 2024

BREAKING CHANGE:

  • ErrorSignal has two new variants: AssertNe and RevertWithLog

@hal3e hal3e added the breaking This change introduces or needs a breaking change label Nov 25, 2024
@hal3e hal3e self-assigned this Nov 25, 2024
@hal3e hal3e mentioned this pull request Nov 25, 2024
Merged
kayagokalp
kayagokalp approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@kayagokalp kayagokalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll be implementing these handlers to sway in language tests (forc-test), thanks for the ping!

@kayagokalp kayagokalp mentioned this pull request Nov 30, 2024
Open
@hal3e hal3e merged commit 47f1289 into master Dec 2, 2024
9 checks passed
@hal3e hal3e deleted the hal3e/add-require-with-log-signal branch December 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kayagokalp kayagokalp kayagokalp approved these changes

@esdrubal esdrubal Awaiting requested review from esdrubal

@IGI-111 IGI-111 Awaiting requested review from IGI-111

Assignees

@hal3e hal3e

Labels
breaking This change introduces or needs a breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hal3e @kayagokalp