TSK Fixes Sample #216
Closed
TSK Fixes Sample #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corecii
commented
Nov 19, 2024
| @@ -29,7 +30,7 @@ def _get_params(ret, candidate, fingerprint, car_fw, disable_openpilot_long, exp | |||
| ret.safetyConfigs[0].safetyParam |= Panda.FLAG_TOYOTA_ALT_BRAKE | |||
|
|
|||
| if ret.flags & ToyotaFlags.SECOC.value: | |||
| ret.secOcRequired = True | |||
| # ret.secOcRequired = True | |||
There was a problem hiding this comment.
Not sure what this was for. Doesn't look like any code used it when I did a find-in-all-files search for secOcRequired so I've just commented it out to get FrogPilot running.
|
Please submit your pull request to the "MAKE-PRS-HERE" branch. |
Corecii
commented
Nov 19, 2024
Comment on lines
+177
to
+178
| result = can_list_to_can_capnp(can_sends, msgtype='sendcan', valid=CS.canValid) | ||
| self.pm.send('sendcan', result) |
There was a problem hiding this comment.
Oops, this is unnecessary. This was part of me debugging why can_list_to_capnp was failing (it was the missing t value in secoc.py)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes fixes necessary to get TSK lat support working for a 2021 Sienna based on comparing FrogPilot-Testing with https://github.com/anbuck/FrogPilot/tree/rav4prime . This successfully makes FrogPilot lateral work on my TSK 2021 Sienna.
Since this PR is on the wrong branch, I'm not expecting it to be merged as-is. I've created it as any easy visualization of what's still missing for TSK support.
Here's a patch file you can use to apply this patch on any branch with
git apply:0001-TSK-Fixes.patch