-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symfony 4.4.* / 5.0.* #639
base: master
Are you sure you want to change the base?
Conversation
Call Form::isSubmitted() before Form::isValid()
…t least get tests to run and fail spectacularly, as expected with: Errors: 21, Failures: 6, Warnings: 18, Incomplete: 2.
Tests: 186, Assertions: 387, Errors: 7, Failures: 3, Warnings: 23, Incomplete: 2.
…e('security.context')); when no token_storage service is set, and throw a new LogicException instead with a message indicating as much. Updated the test to expect the exception instead of the call to replaceArgument.
… what happens when no token storage is available. marked the test as incomplete. - removed reference to templating service from authorize.xml
…cess had to add public getters on objects which really ought to not be there ... which is not great.
…ead of random bytes, to match the repository API's return tyoe of object.
…t in the latest framework
…sing token storage with deprecated security context
Symfony 5 compatibility updates - cleanups and improvements by @iisisrael
Updated functional tests and fixtures
…usive to testing.
More test fixes
Added Mongo functional tests with identified fixes.
Fixed throwing an error with anonymous users
@elchris I guess FOS team is not having time, but is it possible to use your fork in project ? TIA |
Yes it should be fine, see @patrickbussmann 's comment for how to do it. |
I still get error about: #638 while installing it. |
@patrickbussmann would you care to share a sample configuration and installation steps for @napestershine ? @napestershine are you sure that you followed the steps that Patrick outlined here? |
@napestershine: You must read the error message.
So please go to your file and add the
Or when you not using ORM then specify something else - like written in the documentation. |
Any news on this? |
@ruudk @elchris @napestershine many PRs were merged on @elchris could you rebase your PR? With all the work merged, numbers of changes introduced in this PR should decrease. |
yy..yeees I will try tonight. I may need some help if I run into some conflicts for which I'll be uncertain how to resolve but I'll give it a try :) |
Symfony 5 is now supported on master. |
IMHO I think there's something missing in the OAuthStorage class: Password Migration (https://symfony.com/blog/new-in-symfony-4-4-password-migrations).
|
@elchris any support for 5.3 with the new new Authenticator-based Security ? Cannot configure AuthenticatorManager as "fos_oauth" authentication does not support it, set "security.enable_authenticator_manager" to |
@MatthieuMan see #685 - it's based off of main, rather than this branch. |
See #625 starting here.
This pull request also features contributions from @iisisrael - Some more cleanups are still in progress.
If you wish to test this out against my branch in your project ahead of merging, consider looking at this comment by @patrickbussmann