fix: upgrade ci to go 1.23

.github/workflows/codeql.yml

@@ -29,7 +29,7 @@ jobs:
 
     - uses: actions/setup-go@v5
       with:
-        go-version: '1.22'
+        go-version: '1.23'
 
     - name: Initialize CodeQL
       uses: github/codeql-action/init@v3

.github/workflows/go_test.yml

@@ -28,7 +28,7 @@ jobs:
     - name: Set up Go
       uses: actions/setup-go@v5
       with:
-        go-version: "1.22"
+        go-version: '1.23'
         check-latest: true
         cache: true
 

.github/workflows/lint.yml

@@ -30,7 +30,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22"
+          go-version: '1.23'
           check-latest: true
           cache: true
 

.github/workflows/release.yml

@@ -22,7 +22,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22"
+          go-version: '1.23'
           cache: true
           check-latest: true
 

.github/workflows/smoke-test.yml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v5
         with:
-          go-version: "1.22"
+          go-version: '1.23'
           cache: true
           check-latest: true
 

.golangci.yml

@@ -4,12 +4,11 @@ linters:
   disable-all: true
   enable:
     - bodyclose
-    - exportloopref
     - exhaustive
     - goconst
     - gofmt
     - goprintffuncname
-#    - gosec
+    #    - gosec
     - gosimple
     - govet
     - ineffassign
@@ -60,11 +59,9 @@ linters-settings:
       - "Prefix(github.com/FriendsOfShopware/shopware-cli)"
 
 issues:
+  exclude-dirs:
+    - version
   exclude-rules:
     - path: cmd\/*
       linters:
         - forbidigo
-
-run:
-  skip-dirs:
-    - version

account-api/client.go

@@ -58,7 +58,7 @@ func (*Client) doRequest(request *http.Request) ([]byte, error) {
 	}
 
 	if resp.StatusCode >= 400 {
-		return nil, fmt.Errorf(string(data))
+		return nil, fmt.Errorf(string(data)+", got status code %d", resp.StatusCode)
 	}
 
 	return data, nil

account-api/login.go

@@ -116,7 +116,7 @@ func fetchMemberships(ctx context.Context, token token) ([]Membership, error) {
 	}
 
 	if resp.StatusCode != 200 {
-		return nil, fmt.Errorf(string(data))
+		return nil, fmt.Errorf(string(data)+" but got status code %d", resp.StatusCode)
 	}
 
 	var companies []Membership

cmd/project/project_proxy.go

@@ -1,7 +1,7 @@
 package project
 
 import (
-	"fmt"
+	"errors"
 	"os"
 	"os/exec"
 	"runtime"
@@ -35,7 +35,7 @@ var projectProxyCmd = &cobra.Command{
 				message += "See cloudflare for more information: https://developers.cloudflare.com/cloudflare-one/connections/connect-apps/install-and-setup/installation"
 			}
 
-			return fmt.Errorf(message)
+			return errors.New(message)
 		}
 
 		logging.FromContext(cobraCmd.Context()).Infof("Make sure you have set TRUSTED_PROXIES=127.0.0.1,::1 inside your .env file")

extension/asset_platform.go

@@ -353,7 +353,7 @@ func InstallNPMDependencies(path string, packageJsonData NpmPackage, additionalP
 		}
 	}
 
-	if isProductionMode && (packageJsonData.Dependencies == nil || len(packageJsonData.Dependencies) == 0) {
+	if isProductionMode && len(packageJsonData.Dependencies) == 0 {
 		return nil
 	}
 

go.mod

@@ -1,6 +1,6 @@
 module github.com/FriendsOfShopware/shopware-cli
 
-go 1.21
+go 1.23
 
 require (
 	dario.cat/mergo v1.0.1