Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use esbuild when possible for project builds #249

Merged
merged 4 commits into from
Dec 10, 2023

Conversation

shyim
Copy link
Member

@shyim shyim commented Nov 3, 2023

Right now shopware-cli project ci uses the traditional steps like build-administration.sh and build-storefront.sh

Since a while we support esbuild for building extensions much faster without access to the Shopware source code. To adopt this for building multiple extensions, we know split the extensions:

  • ESBuild compatible admin/storefront now will always be build with esbuild.
  • Any non-compatible extension will use the regular complication

So we have the best of both worlds. Some extensions build faster and which are not compatible use the regular setup.

Some benchmarks:

Project: All extensions have esbuild support.

  • shopware project ci (current version): 1 minute build time.
  • shopware project ci (this branch): 29 seconds build time.

I think the improvement can be better seen in CI like GitHub Actions with limited amount of resources. My machine has 16 cores, 128gb memory, little bit overkill to compare, but still 2x faster than the previous version.

Copy link

github-actions bot commented Nov 3, 2023

Qodana for Go

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

@shyim shyim force-pushed the refactor-asset-building-with-esbuild branch 2 times, most recently from 6685b08 to a916b56 Compare November 3, 2023 12:48
@shyim shyim force-pushed the refactor-asset-building-with-esbuild branch from a916b56 to 3eb4abf Compare December 3, 2023 21:53
@shyim shyim changed the title feat: move esbuild compatible to asset source feat: use esbuild when possible for project builds Dec 3, 2023
@shyim shyim force-pushed the refactor-asset-building-with-esbuild branch from e0a15b3 to 67cc9fb Compare December 10, 2023 08:56
@shyim shyim merged commit ce80e8b into main Dec 10, 2023
7 checks passed
@shyim shyim deleted the refactor-asset-building-with-esbuild branch December 10, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant