Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add project configration inheritance support #234

Conversation

Jnoack331
Copy link
Contributor

@Jnoack331 Jnoack331 commented Oct 2, 2023

This would help with configuration managment because you can extend another .shopware-project.yml file to reuse or override configurations. This is useful when you have multiple projects with the same configuration. You can also use this to create a base configuration for your stages or teams and extend it for your own needs.
This also can be used to toggle specific plugin configurations for different stages e.g. enabling/disabling the Paypal sandbox mode depending on the environment.

@shyim
Copy link
Member

shyim commented Oct 2, 2023

What do you think about naming it include and allow to be an array of files? In that way we would support multiple files.

Little bit like docker compose https://docs.docker.com/compose/multiple-compose-files/include/

@Jnoack331
Copy link
Contributor Author

@shyim sure, i guess the priority would be set by the order of the files provided?

@shyim
Copy link
Member

shyim commented Oct 2, 2023

yes :)

@Jnoack331
Copy link
Contributor Author

@shyim Just looked a bit into the docker documentation. That include change would reverse the override logic correct? Would that mean an include could override a value in the current configuration, or is this handled differently in docker compose?

@Jnoack331
Copy link
Contributor Author

@shyim I changed it so its now using the include statement with multiple files to include. I didnt change the base merge logic so that values from the main file always have priority, this is propably the most intuitive.

@shyim shyim merged commit a14e097 into FriendsOfShopware:main Oct 9, 2023
4 of 5 checks passed
@shyim
Copy link
Member

shyim commented Oct 9, 2023

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants