Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change condition for filter gambit #111

Closed
wants to merge 1 commit into from
Closed

Conversation

DavideIadeluca
Copy link
Member

Fixes #0000

Report by @novacuum

I stumbled upon this change: b970103
My indention was to select discussions without a solved post, but this is not possible, as in the negation it excludes the discussions which have the tags with qna enabled.
From my understanding, the method call in line 54 (old code) was correct, only the field was wrong.
It should only change the check for discussions.best_answer_post_id , is null or notnull

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca added the bug Something isn't working label Nov 21, 2024
@DavideIadeluca DavideIadeluca self-assigned this Nov 21, 2024
@DavideIadeluca DavideIadeluca marked this pull request as draft November 21, 2024 09:49
@DavideIadeluca DavideIadeluca removed the request for review from imorland November 21, 2024 09:49
@DavideIadeluca DavideIadeluca deleted the di/fix branch November 21, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant