Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: TS refactor #107

Merged
merged 28 commits into from
Nov 2, 2024
Merged

chore: TS refactor #107

merged 28 commits into from
Nov 2, 2024

Conversation

imorland
Copy link
Member

@imorland imorland commented Oct 23, 2024 •
edited
Loading

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:
Please give this a spin over locally. I did the same, but just in case I missed something

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@imorland imorland changed the title wip: full ts chore: TS refactor Oct 31, 2024
@imorland imorland marked this pull request as ready for review October 31, 2024 22:32
@DavideIadeluca DavideIadeluca added the enhancement New feature or request label Nov 1, 2024
DavideIadeluca
DavideIadeluca requested changes Nov 1, 2024
View reviewed changes
Copy link
Member

@DavideIadeluca DavideIadeluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything appears to be working locally as expected. There are some suggestions I have for typings though, including some changes I picked up that are unrelated to this PR

js/src/forum/addBestAnswerCountToUsers.tsx Outdated Show resolved Hide resolved
js/src/@types/shims.d.ts Outdated Show resolved Hide resolved
js/src/forum/components/BestAnswerBadge.tsx Show resolved Hide resolved
js/src/forum/components/BestAnswerInDiscussionNotification.ts Outdated Show resolved Hide resolved
js/src/forum/components/AwardedBestAnswerNotification.ts Outdated Show resolved Hide resolved
js/src/forum/extend.ts Outdated Show resolved Hide resolved
js/src/forum/components/SolutionSearchItem.tsx Outdated Show resolved Hide resolved
js/src/forum/components/SolutionSearchItem.tsx Outdated Show resolved Hide resolved
js/src/forum/components/SolutionSearchItem.tsx Outdated Show resolved Hide resolved
js/src/forum/components/SelectBestAnswerNotification.ts Outdated Show resolved Hide resolved
imorland and others added 16 commits November 1, 2024 20:02
@imorland
fix: add a11y label to jump button
6c77ba5
@imorland @DavideIadeluca
Update js/src/forum/components/SelectBestAnswerNotification.ts
0e4c161 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/components/SolutionSearchItem.tsx
0896f79 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/components/SolutionSearchItem.tsx
45d0f8b 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/components/SolutionSearchItem.tsx
9771c9b 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/extend.ts
7dda67a 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/extenders/extendDiscussionComposer.tsx
12e9a89 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/extenders/extendDiscussionSearchSource.tsx
4ab4534 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/components/AwardedBestAnswerNotification.ts
151537b 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/components/BestAnswerInDiscussionNotification.ts
cdb4c5a 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland
chore: remove unneeded tsignore
b3706dc
@imorland @DavideIadeluca
Update js/src/forum/addBestAnswerCountToUsers.tsx
da39943 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/@types/shims.d.ts
63e97d4 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/@types/shims.d.ts
fb2c686 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/extenders/extendIndexPage.tsx
6a8a887 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland @DavideIadeluca
Update js/src/forum/extenders/extendIndexPage.tsx
1527ed0 
Co-authored-by: Davide Iadeluca <[email protected]>
@imorland imorland assigned DavideIadeluca and unassigned imorland Nov 1, 2024
@imorland imorland merged commit 95aa3c6 into master Nov 2, 2024
34 checks passed
@imorland imorland deleted the im/ts branch November 2, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavideIadeluca DavideIadeluca DavideIadeluca approved these changes

Assignees

@imorland imorland

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imorland @DavideIadeluca