Update ml-kit integration #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @GaborAbonyi. Thanks for this update. Could you update the spelling dictionary at .github/.cSpellWords.txt to include "IRQN"? This should satisfy the spell checker. |
|
I found some additional typos. Just rerunning some local tests to be sure. I'll push the update soon. |
GaborAbonyi
force-pushed
the
dev/gabor.abonyi/new_mlkit_integration
branch
from
3e995cf to
d056711
Compare
GaborAbonyi
changed the title
GaborAbonyi
force-pushed
the
dev/gabor.abonyi/new_mlkit_integration
branch
from
d056711 to
9c4b378
Compare
GaborAbonyi
changed the title
This prevents the module from always being included even when building applications that do not require it. Signed-off-by: Gabor Abonyi <[email protected]>
Use the -additional-ethos-u-config-name option to generate required NPU optimization instead of patching default list. Signed-off-by: Gabor Abonyi <[email protected]>
Instead of building the whole project as an external project, only build the necessary libraries. Rename BuildMLEmbeddedEvaluationKit.cmake to SetupMlEmbeddedEvaluationKitLibraries.cmake This change also uses the NPU driver component from ML Evaluation Kit which results in the following changes: * Modify initialization of NPU in AI applications to use API provided by the component * Add ICache and DCache enablement options as caches are used in the NPU component * Include various patches for the NPU component. * Remove ML Evaluation Kit device drivers header files inclusions as they are no longer used as we are now using the NPU component for initializing the NPU. Signed-off-by: Gabor Abonyi <[email protected]>
* Improved tensorflow.cmake * Model URLs file location has changed * Some patches have been merged upstream Signed-off-by: Gabor Abonyi <[email protected]>
urutva
approved these changes
Feb 6, 2024
GaborAbonyi
force-pushed
the
dev/gabor.abonyi/new_mlkit_integration
branch
from
9c4b378 to
80e220f
Compare
|
Rebased to latest origin/main as another PR was merged. Now PR is finalized and ready. |
aggarg
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update ml-kit integration
Description
Use ML Embedded Evaluation kit as a collection of libraries, instead of building it as an external project.
Update ML-kit version to 23.11
Test Steps
Compiled and run the available examples with GCC and Armclang for Corstone-300 and 310.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.