Fix dependence of special Python builds for CAN #649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rumpelsepp
commented
Dec 17, 2024
rumpelsepp
commented
- chore: mv misc -> scripts
- fix: Remove dependence on special Python builds for CAN functionality
The CAN constants are compiled in depending in the enabled kernel features. In case a Python interpreter is built in a special environment (e.g., https://github.com/indygreg/python-build-standalone used by the uv tool), then a few constants might be missing. The absence of these constants does not limit the availability of the CAN feature on a supported kernel. So, lets checkin a generated file with the correct constants to avoid running into this problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.