chore: Introduce pip support and make uv optional #644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to run |
rumpelsepp
approved these changes
Dec 9, 2024
Added a fixup commit; feel free to apply it accordingly and merge it at your convenience! Many thanks! |
The current implementation of the pyproject.toml does not allow to install all requirements for dev environments to be installed with pip. While PEP 735 is accepted since almost two months, pip does not support it yet. Instead, we rely on PEP 621 and by using optional-dependencies we can for now support pip by allowing to install the dev dependencies by specifying extras, such as pip install .[dev] This can be reverted once pypa/pip#12963 is resolved.
By calling `uv run make lint` instead, this commit drops the requirement for uv.
rumpelsepp
force-pushed
the
pip-support
branch
from
a1acd04 to
bddedc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the pyproject.toml does not allow to install all requirements for dev environments to be installed with pip. While PEP 735 is accepted since almost two months, pip does not support it yet.
Instead, we rely on PEP 621 and by using optional-dependencies we can for now support pip by allowing to install the dev dependencies by specifying extras, such as
pip install .[dev]
This can be reverted once pypa/pip#12963 is resolved.