Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix getting broadcast addresses #638

Merged
merged 3 commits into from
Dec 5, 2024
Merged

Fix getting broadcast addresses #638

merged 3 commits into from
Dec 5, 2024

Conversation

rumpelsepp
Copy link
Member

  • fix: Correct if condition for broadcast addresses
  • refactor: Move function to utils
  • fix: Use ip address as a string value

@rumpelsepp rumpelsepp added the bug Something isn't working label Dec 5, 2024
@rumpelsepp rumpelsepp added this to the gallia 2.0 milestone Dec 5, 2024
@rumpelsepp
Copy link
Member Author

/cc @fkglr

@rumpelsepp rumpelsepp merged commit 2dfbfab into master Dec 5, 2024
12 checks passed
@rumpelsepp rumpelsepp deleted the broadcast branch December 5, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferdinandjarisch ferdinandjarisch Awaiting requested review from ferdinandjarisch ferdinandjarisch is a code owner

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
gallia 2.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rumpelsepp