Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallia 2 fix #636

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Gallia 2 fix #636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
301f75e
fix(config): Copy init_kwargs to avoid potentially surprising side ef…
fkglr Dec 3, 2024
cc9a2d4
Mark currently not used parameter
fkglr Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/gallia/command/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,11 +301,8 @@ class GalliaBaseModel(BaseCommand, ABC):
__config_registry: dict[str, tuple[str, Any]]

def __init__(self, **data: Any):
init_kwargs = data.pop("init_kwargs", {})

if init_kwargs is None:
init_kwargs = {}

# Copy to avoid side effects when reusing init_kwargs
init_kwargs = dict(data.pop("init_kwargs", {}))
init_kwargs.update(data)

super().__init__(**init_kwargs)
Expand Down
4 changes: 3 additions & 1 deletion src/gallia/commands/scan/uds/services.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ class ServicesScannerConfig(UDSScannerConfig):
False, description="check current session; only takes affect if --sessions is given"
)
scan_response_ids: bool = Field(False, description="Include IDs in scan with reply flag set")
auto_reset: bool = Field(False, description="Reset ECU with UDS ECU Reset before every request")
auto_reset: bool = Field(
False, description="Reset ECU with UDS ECU Reset before every request"
) # FIXME: Currently not in use
skip: Ranges2D = Field(
{},
metavar="SESSION_ID:ID",
Expand Down
Loading