DoIP fixes and grand speed-up in discovery #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferdinandjarisch
force-pushed
the
doip-speedups
branch
from
71f872c to
6e61b58
Compare
rumpelsepp
reviewed
Dec 3, 2024
rumpelsepp
reviewed
Dec 3, 2024
|
Looks good. However, I would motivate to avoid copy+pasted code and refactor this part. |
Previously we waited for each valid target_address for the ECU to reply. This commit introduces a parallel approach where diagnostic message replies are treated independently of their requests which resolves virtually all waits for timeouts except at the very end during the target address enumeration.
rumpelsepp
force-pushed
the
doip-speedups
branch
from
211d786 to
32ce4ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.