chore: Remove aiofiles dependency #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
rumpelsepp
force-pushed
the
noaiofiles
branch
2 times, most recently
from
d503019 to
54f2ba7
Compare
We only write very small files. Unless the artifactsdir is located on a, e.g., very slow network drive, it is very unlikely that the eventloop is blocked by these writes. Usually only a few bytes are written to dumpfiles or to separate result files. Let's use the stdlib instead and get rid of a further dependency.
rumpelsepp
force-pushed
the
noaiofiles
branch
from
54f2ba7 to
deb43c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only write very small files. Unless the artifactsdir is located on a,
e.g., very slow network drive, it is very unlikely that the eventloop is
blocked by these writes. Usually only a few bytes are written to
dumpfiles or to separate result files.
Let's use the stdlib instead and get rid of a further dependency.
See also: #582, #590, #591, #595