Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hanging tests due to a python bug #478

Merged
merged 4 commits into from
Dec 8, 2023
Merged

fix hanging tests due to a python bug #478

merged 4 commits into from
Dec 8, 2023

Conversation

rumpelsepp
Copy link
Member

@rumpelsepp rumpelsepp commented Dec 8, 2023

  • flake.lock: Update
  • chore: Add python 3.12 to flake.nix
  • chore: Fix deprecation warning
  • fix(tests): Fix hanging tests

The exceptions in the Python 3.12 tests are a regression and will be fixed in 3.12.1; nothing to do here: python/cpython#109538

Flake lock file updates:

• Updated input 'nixpkgs':
    'github:nixos/nixpkgs/b56f06f3e8c6f48973a43765f4b02c756ba30da4' (2023-10-02)
  → 'github:nixos/nixpkgs/6a6d3373898c5fbd3ab8626e965f8b80cc932bb4' (2023-12-08)
There is a Python bug with .wait_closed(); just remove this invocation.

* python/cpython#104344
* python/cpython#109538
@rumpelsepp rumpelsepp requested a review from peckto as a code owner December 8, 2023 13:07
@rumpelsepp rumpelsepp changed the title tests2 fix hanging tests due to a python bug Dec 8, 2023
@rumpelsepp rumpelsepp added the bug Something isn't working label Dec 8, 2023
@rumpelsepp rumpelsepp merged commit 43a3832 into master Dec 8, 2023
11 checks passed
@rumpelsepp rumpelsepp deleted the tests2 branch December 8, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant