Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small fixes here and there #474

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Small fixes here and there #474

merged 7 commits into from
Jan 4, 2024

Conversation

ferdinandjarisch
Copy link
Contributor

No description provided.

ferdinandjarisch
ferdinandjarisch commented Dec 15, 2023
View reviewed changes
src/gallia/log.py Outdated Show resolved Hide resolved
@ferdinandjarisch
Copy link
Contributor Author

@rumpelsepp What blocks this?

@ferdinandjarisch ferdinandjarisch marked this pull request as ready for review December 22, 2023 13:19
rumpelsepp
rumpelsepp reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@rumpelsepp rumpelsepp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you wrote your comment, this was still labeled as a draft, therefore I did not investigate further. I added my comments.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
.github/workflows/tests.yml Outdated Show resolved Hide resolved
src/gallia/dumpcap.py Outdated Show resolved Hide resolved
src/gallia/log.py Outdated Show resolved Hide resolved
src/gallia/services/uds/ecu.py Show resolved Hide resolved
src/gallia/services/uds/ecu.py Outdated Show resolved Hide resolved
@ferdinandjarisch ferdinandjarisch force-pushed the tp-shenanigangs branch 2 times, most recently from b45ecd3 to fbcea43 Compare January 2, 2024 14:57
@ferdinandjarisch
Copy link
Contributor Author

As mentioned by @VeroSec

Tested Branch. asyncio and teardown errors have been fixed.
Only one error remains with python3.11:
Exception ignored in: <function StreamWriter.__del__ at 0x7ff712588c20> Traceback (most recent call last): File "/usr/lib/python3.11/asyncio/streams.py", line 395, in __del__ File "/usr/lib/python3.11/asyncio/streams.py", line 343, in close File "/usr/lib/python3.11/asyncio/selector_events.py", line 860, in close File "/usr/lib/python3.11/asyncio/base_events.py", line 761, in call_soon File "/usr/lib/python3.11/asyncio/base_events.py", line 519, in _check_closed RuntimeError: Event loop is closed

This is an issue in cypthon and should be fixed in 3.11.7 onwards as far as I understood!

@rumpelsepp rumpelsepp mentioned this pull request Jan 3, 2024
Closed
@Fraunhofer-AISEC Fraunhofer-AISEC deleted a comment from VeroSec Jan 4, 2024
@ferdinandjarisch
Copy link
Contributor Author

@rumpelsepp rebased and ready to merge.

Does it need any more approval or can I press merge once jobs succeded?

@rumpelsepp rumpelsepp merged commit 88d222c into master Jan 4, 2024
11 checks passed
@rumpelsepp rumpelsepp deleted the tp-shenanigangs branch January 4, 2024 15:27
@rumpelsepp rumpelsepp restored the tp-shenanigangs branch January 4, 2024 15:27
@rumpelsepp rumpelsepp deleted the tp-shenanigangs branch January 4, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rumpelsepp rumpelsepp rumpelsepp left review comments

@fkglr fkglr Awaiting requested review from fkglr

@peckto peckto Awaiting requested review from peckto peckto is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ferdinandjarisch @rumpelsepp