Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: analyzer #205

Draft
wants to merge 26 commits into
base: master
Choose a base branch
from
Draft

feat: analyzer #205

wants to merge 26 commits into from

Conversation

peckto
Copy link
Contributor

@peckto peckto commented Jul 5, 2022

Adding a draft version of the gallia analyzer to analyze and visualize scan results.
Credit goes to @chanyoungso

Example usage:

$ poetry install --extras analyzer
$ poetry shell
$ gallia analyze -aer --source gallia.db

Open points:

@peckto peckto added the enhancement New feature or request label Jul 5, 2022
@peckto peckto added this to the v1.3.0 milestone Jul 5, 2022
@peckto peckto requested a review from rumpelsepp as a code owner July 5, 2022 05:40
@peckto peckto mentioned this pull request Jul 5, 2022
@peckto peckto force-pushed the analyzer branch 5 times, most recently from e8eb005 to e8b3ee4 Compare August 1, 2022 06:24
@peckto
Copy link
Contributor Author

peckto commented Aug 8, 2022

Because the information in the tables vendor_lookup and vendor_session are ECU specific and we can have results from multiple ECUs in one database, we need a mapping between the vendor specific information and the ECU.

To implement this mapping, we have two possibilities:

  1. Create a "vendor_lookup_id" column in the ECU table (1:Vendor Lookup -> n:ECUs)
  2. Create a "cross_vendor_lookup_ecu" table (n:Vendor Lookup -> m:ECUs)

My first guess would be (2), this is more flexible and we do not need to store vendor/analyzer specific information in the ECU table.

@rumpelsepp
Copy link
Member

Poetry 1.2 is out. Maybe this helps with making the analyzer optional:

https://python-poetry.org/docs/pyproject/#scripts

@rumpelsepp rumpelsepp force-pushed the master branch 6 times, most recently from 72a5ecf to 41e0a13 Compare October 11, 2022 10:22
@rumpelsepp rumpelsepp force-pushed the master branch 3 times, most recently from 981f73a to 5218514 Compare October 25, 2022 09:04
@rumpelsepp rumpelsepp removed this from the v1.3.0 milestone Nov 15, 2023
Copy link

stale bot commented Jul 14, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 14, 2024
@peckto peckto marked this pull request as draft July 24, 2024 12:48
@stale stale bot removed the stale label Jul 24, 2024
@peckto
Copy link
Contributor Author

peckto commented Jul 24, 2024

rebased to current master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants