Skip to content

Commit

Permalink
fix(doip): Do not raise TimeoutError when receiving DoIP-NACK
Browse files Browse the repository at this point in the history
acc80e7 moved raising TargetUnreachable
NACKs to the higher-level write function, but erroneously introduced
raising a TimeOutError instead.
  • Loading branch information
ferdinandjarisch committed Oct 10, 2023
1 parent 4f958c0 commit 3e67c63
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/gallia/transports/doip.py
Original file line number Diff line number Diff line change
Expand Up @@ -678,8 +678,7 @@ async def write(
raise e
# TargetUnreachable can be just a temporary issue. Thus, we do not raise
# BrokenPipeError but instead ignore it here and let upper layers handle
# missing responses (i.e. raise a TimeoutError instead)
# missing responses
logger.debug("DoIP message was ACKed with TargetUnreachable")
raise asyncio.TimeoutError from e

return len(data)

0 comments on commit 3e67c63

Please sign in to comment.