Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python: Handle formattedValue #1864

Merged
merged 17 commits into from
Dec 2, 2024
Merged

Python: Handle formattedValue #1864

merged 17 commits into from
Dec 2, 2024

Conversation

lshala
Copy link
Contributor

@lshala lshala commented Nov 21, 2024 •
edited
Loading

This PR adds the handling for formattedValue's.

@lshala lshala changed the title Handle formattedValue Python: Handle formattedValue Nov 21, 2024
@lshala lshala marked this pull request as ready for review November 22, 2024 13:54
@codecov Codecov
Copy link

codecov bot commented Nov 22, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 76.44%. Comparing base (eee46c2) to head (057b147).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...er/aisec/cpg/frontends/python/ExpressionHandler.kt 86.00% 3 Missing and 4 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...er/aisec/cpg/frontends/python/ExpressionHandler.kt 81.27% <86.00%> (+5.99%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

maximiliankaul
maximiliankaul reviewed Nov 26, 2024
View reviewed changes
Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, this looks good to me. There are some confusions / bugs that have to be resolved before approving, though.

maximiliankaul
maximiliankaul approved these changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge once the conversations have been resolved. Nice PR 👍

@KuechA KuechA enabled auto-merge (squash) December 2, 2024 10:24
@KuechA KuechA disabled auto-merge December 2, 2024 10:24
@KuechA KuechA enabled auto-merge (squash) December 2, 2024 13:21
@KuechA KuechA merged commit d40f4eb into main Dec 2, 2024
2 checks passed
@KuechA KuechA deleted the ls/handle-formatted-values branch December 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximiliankaul maximiliankaul maximiliankaul approved these changes

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lshala @maximiliankaul @KuechA @oxisto