Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing legacy resolveReference function #1861

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 21, 2024

This PR tries to remove the resolveReference function.

@oxisto oxisto changed the title remove more legacy code Removing legacy resolveReference function Nov 21, 2024
@oxisto oxisto added the blocked Blocked by an external factor label Nov 21, 2024
@oxisto
Copy link
Member Author

oxisto commented Nov 21, 2024

Blocked by #1862

@oxisto oxisto force-pushed the remove-more-legacy-code branch from 20cc1a7 to 9d5f539 Compare November 28, 2024 21:00
Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 86.27451% with 14 lines in your changes missing coverage. Please review.

Project coverage is 76.30%. Comparing base (d2c7f28) to head (bbcad1c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...in/de/fraunhofer/aisec/cpg/passes/JavaExtraPass.kt 68.75% 0 Missing and 5 partials ⚠️
...n/de/fraunhofer/aisec/cpg/passes/SymbolResolver.kt 81.25% 1 Missing and 2 partials ⚠️
...raunhofer/aisec/cpg/passes/inference/PassHelper.kt 50.00% 0 Missing and 3 partials ⚠️
...n/de/fraunhofer/aisec/cpg/passes/ImportResolver.kt 83.33% 0 Missing and 2 partials ⚠️
...hofer/aisec/cpg/frontends/cxx/ExpressionHandler.kt 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 80.62% <ø> (+3.31%) ⬆️
...fer/aisec/cpg/passes/TemplateCallResolverHelper.kt 80.20% <100.00%> (+1.31%) ⬆️
...lin/de/fraunhofer/aisec/cpg/passes/TypeResolver.kt 95.74% <100.00%> (+0.18%) ⬆️
...s/kotlin/de/fraunhofer/aisec/cpg/test/TestUtils.kt 71.87% <ø> (+0.29%) ⬆️
.../fraunhofer/aisec/cpg/frontends/cxx/CPPLanguage.kt 90.25% <100.00%> (+0.19%) ⬆️
...ofer/aisec/cpg/frontends/cxx/DeclarationHandler.kt 79.40% <100.00%> (ø)
...tlin/de/fraunhofer/aisec/cpg/passes/GoExtraPass.kt 79.03% <100.00%> (+0.34%) ⬆️
...ofer/aisec/cpg/frontends/java/ExpressionHandler.kt 77.80% <100.00%> (+5.36%) ⬆️
...r/aisec/cpg/frontends/java/JavaLanguageFrontend.kt 68.12% <100.00%> (-3.94%) ⬇️
...hofer/aisec/cpg/frontends/cxx/ExpressionHandler.kt 71.99% <75.00%> (+0.10%) ⬆️
... and 4 more

... and 9 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by an external factor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant