Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First part of scope cleanup #1856

Merged
merged 10 commits into from
Dec 2, 2024
Merged

First part of scope cleanup #1856

merged 10 commits into from
Dec 2, 2024

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Nov 20, 2024

  • Renamed BlockScope to LocalScope
  • Removed LoopScope
  • Removed TryScope
  • Removed SwitchScope
  • Introduced a new NamespaceScope that is specific to namespaces, to differentiate between namespaces and records

@oxisto oxisto force-pushed the cleanup-scopes-part1 branch from b58f9f2 to 6dab1a6 Compare November 20, 2024 11:37
@oxisto oxisto marked this pull request as ready for review November 20, 2024 13:46
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 72.72727% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.50%. Comparing base (d40f4eb) to head (150ad6a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 66.66% 1 Missing and 3 partials ⚠️
...fraunhofer/aisec/cpg/frontends/golang/GoHandler.kt 50.00% 0 Missing and 1 partial ⚠️
...fer/aisec/cpg/frontends/python/StatementHandler.kt 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
...de/fraunhofer/aisec/cpg/graph/scopes/LocalScope.kt 100.00% <100.00%> (ø)
.../de/fraunhofer/aisec/cpg/graph/scopes/NameScope.kt 80.00% <100.00%> (ø)
...raunhofer/aisec/cpg/graph/scopes/NamespaceScope.kt 100.00% <100.00%> (ø)
...tlin/de/fraunhofer/aisec/cpg/graph/scopes/Scope.kt 84.28% <100.00%> (+2.34%) ⬆️
...isec/cpg/graph/scopes/StructureDeclarationScope.kt 81.25% <100.00%> (-1.11%) ⬇️
...er/aisec/cpg/graph/scopes/ValueDeclarationScope.kt 50.00% <100.00%> (ø)
...fraunhofer/aisec/cpg/frontends/golang/GoHandler.kt 73.52% <50.00%> (-2.23%) ⬇️
...fer/aisec/cpg/frontends/python/StatementHandler.kt 84.61% <50.00%> (ø)
...ain/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt 81.69% <66.66%> (+1.13%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading the code looks good. No major concerns. I'll have to play with this branch a bit to get an understanding of these changes before I click "approve", though.

* Renamed `BlockScope` to `LocalScope`
* Removed `LoopScope`
* Removed `TryScope`
* Removed `SwitchScope`
@oxisto oxisto force-pushed the cleanup-scopes-part1 branch from 8c9b082 to 1ce6e0c Compare November 29, 2024 21:59
@oxisto oxisto enabled auto-merge (squash) December 2, 2024 12:50
@oxisto oxisto merged commit aad282e into main Dec 2, 2024
2 checks passed
@oxisto oxisto deleted the cleanup-scopes-part1 branch December 2, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants