-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First part of scope cleanup #1856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
cleanup-scopes-part1
branch
from
November 20, 2024 11:37
b58f9f2
to
6dab1a6
Compare
oxisto
requested review from
maximiliankaul,
lshala,
konradweiss and
KuechA
as code owners
November 20, 2024 13:46
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading the code looks good. No major concerns. I'll have to play with this branch a bit to get an understanding of these changes before I click "approve", though.
* Renamed `BlockScope` to `LocalScope` * Removed `LoopScope` * Removed `TryScope` * Removed `SwitchScope`
oxisto
force-pushed
the
cleanup-scopes-part1
branch
from
November 29, 2024 21:59
8c9b082
to
1ce6e0c
Compare
KuechA
approved these changes
Dec 2, 2024
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BlockScope
toLocalScope
LoopScope
TryScope
SwitchScope
NamespaceScope
that is specific to namespaces, to differentiate between namespaces and records