-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create one Type
object per type reference
#1773
Conversation
4f5828a
to
64ba3ef
Compare
38bb9d0
to
782689a
Compare
782689a
to
c2002ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not encounter any specific issues, however I would like to get the test coverage up if possible with meaningful tests. We should also look into how these changes impact performance
80561a3
to
1daf06b
Compare
The missing coverage is mostly due to the low coverage in the DFG function summaries, which I needed to change because of a rename and this drags into bad patch coverage :( |
It's faster. 150s vs 200s on the nova benchmark |
0543ec8
to
af6be91
Compare
Fixes #1768
Benchmark Results
Based on nova (without tests and without CDG/PDG)
Before:
After: