Implement AST parent edges #1479
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
mk/backwards-ast
branch
from
6faff13 to
6eee05b
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Due to a bug in the symbol resolver, we did not resolve fields that are in base classes of classes incorrectly
This PR adds the way `Type.isDerivedFrom` works. More concretly, we are once again taking the "wrap state" of the type into account. This means that pointer types and non-pointer types will not match even though their root types derive from each other. This was the way this function behaved in the past and it seems this was changed at some point, which led to some weird over-approximations in call resolving, basically ignoring wether a type was a pointer or not.
* Extracted call/cast replacement into separate pass Multiple languages, such as Go and C++ support "functional style casts", in the form of int(5). During the frontend parsing, they are indistinguishable from function calls. Therefore, we need to do a cleanup after all types are known but before other passes are invoked that replace those calls with casts. The proposed solution is to include a new language trait HasFuntionalCasts and to move the logic from the GoExtraPass into a separate, language-neutral one. Fixes #1487 * Added annotation to pass that requires a language trait
* Fix style of docs * Clean DFG spec a bit * re-generate graph schema with minor style updates
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
* Add BoolOp and + or * nicer error handling * Add some messages to better debug the TODO()s in the future --------- Co-authored-by: Alexander Kuechler <[email protected]>
* Fixing javaparser resultion error * Always use our scope manager --------- Co-authored-by: Alexander Kuechler <[email protected]>
oxisto
added a commit
that referenced
this pull request
Jul 18, 2024
Provides an API similar to #1479 but different approach for setting the AST parent Co-Authored-By: Maximilian Kaul <[email protected]>
Slightly inspired by discussion with @konradweiss. This adds a helper function to set the ast parent in cases where the node cannot be created within the `withChildren` block.
5 tasks
oxisto
added a commit
that referenced
this pull request
Jul 31, 2024
Provides an API similar to #1479 but different approach for setting the AST parent Co-Authored-By: Maximilian Kaul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP!
withChildrenstyle #1621thisin nested blocks is not anASTStackProvider