Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to PDG/CDG #1401

Merged
merged 4 commits into from
Dec 30, 2023
Merged

Fixes to PDG/CDG #1401

merged 4 commits into from
Dec 30, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Dec 30, 2023 •
edited
Loading

This PR:

  • Tries to remove some confusing edges from PDG
  • Fixed an endless loop in PDG

It is cherry-picked and cleaned up from #1382

@oxisto oxisto requested a review from konradweiss as a code owner December 30, 2023 10:34
@oxisto oxisto changed the title pdg cdg fixes Fixes to PDG/CDG Dec 30, 2023
@oxisto oxisto enabled auto-merge (squash) December 30, 2023 10:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 30, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

74.6% Coverage on New Code (required ≥ 75%)

See analysis details on SonarCloud

@oxisto oxisto merged commit 460ad7d into main Dec 30, 2023
3 of 4 checks passed
@oxisto oxisto deleted the pdg-cdg-fixes branch December 30, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oxisto @KuechA @morbitzer