Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use IdentitySet and IdentityHashMap in EOG iteration for CF-DFG to improve performance #1369

Merged
merged 3 commits into from
Nov 24, 2023
Merged

Use IdentitySet and IdentityHashMap in EOG iteration for CF-DFG to improve performance #1369

merged 3 commits into from
Nov 24, 2023

Conversation

KuechA
Copy link
Contributor

@KuechA KuechA commented Nov 23, 2023

No description provided.

@oxisto
Copy link
Member

oxisto commented Nov 23, 2023

Could this also be used in the implementation of PowersetLattice? I noticed when stepping through a large program that it seems that a lot of time is spent in duplicate, which seems to use a regular Set.

@oxisto
Copy link
Member

oxisto commented Nov 23, 2023 •
edited
Loading

Could this also be used in the implementation of PowersetLattice? I noticed when stepping through a large program that it seems that a lot of time is spent in duplicate, which seems to use a regular Set.

I have implemented this very quickly and it seems that this provides another performance boost. In my example, the CF-DFG went from 26s to 18s.

@oxisto oxisto changed the title Try some minor efficiency improvements in EOG iteration: use IdentityHashMaps Use IdentitySet and IdentityHashMap in EOG iteration for CF-DFG to improve performance Nov 23, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

90.6% 90.6% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit a67b5fa into main Nov 24, 2023
4 checks passed
@oxisto oxisto deleted the eog-worklist-identity-map branch November 24, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxisto oxisto oxisto approved these changes

@konradweiss konradweiss Awaiting requested review from konradweiss konradweiss is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KuechA @oxisto