Performance improvements for CXX frontend #1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oxisto
force-pushed
the
optimize-cxx-frontend
branch
2 times, most recently
from
e93d144 to
8cd23e1
Compare
Previously, in the CXX frontend, we were supplying the `rawSignature` as code(override) to almost all functions that created nodes. The issue with that is, that this does not respect the `codeInNodes` config option, which might be turned on to save memory. This PR consequently uses the `rawNode` parameter, which forwards setting code and location to the language frontend, which DOES respect the `codeInNodes` option.
oxisto
force-pushed
the
optimize-cxx-frontend
branch
from
8cd23e1 to
e27db37
Compare
|
Kudos, SonarCloud Quality Gate passed! |
oxisto
added a commit
that referenced
this pull request
Nov 24, 2023
* Performance improvements for CXX frontend * Avoid using `rawSignature` directly when creating nodes (#1362) Previously, in the CXX frontend, we were supplying the `rawSignature` as code(override) to almost all functions that created nodes. The issue with that is, that this does not respect the `codeInNodes` config option, which might be turned on to save memory. This PR consequently uses the `rawNode` parameter, which forwards setting code and location to the language frontend, which DOES respect the `codeInNodes` option. * Added complexity and mermaid chart * More cleanup of old typedef remnants
oxisto
added a commit
that referenced
this pull request
Nov 28, 2023
* Performance improvements for CXX frontend * Avoid using `rawSignature` directly when creating nodes (#1362) Previously, in the CXX frontend, we were supplying the `rawSignature` as code(override) to almost all functions that created nodes. The issue with that is, that this does not respect the `codeInNodes` config option, which might be turned on to save memory. This PR consequently uses the `rawNode` parameter, which forwards setting code and location to the language frontend, which DOES respect the `codeInNodes` option. * Added complexity and mermaid chart * More cleanup of old typedef remnants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not directly in the CXX frontend, this makes typedef resolution MUCH faster, leading to cases where the CXX frontend (which almost uses this exclusively) was about 50 % faster.