Make control-flow sensitive DFG pass configurable by complexity #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing MAJOR performance problems, since we are using the `hashCode` in the symbol resolver for caching. This had the effect that on deeply nested scopes, performance dropped quite largely.
This calculates a simple cylic complexity for functions and adds a configuration option to specify a max for the control-flow sensitive DFG pass.
oxisto
changed the title
oxisto
force-pushed
the
cyclic-complexity
branch
from
a2411da to
b58cdab
Compare
|
SonarCloud Quality Gate failed.
|
KuechA
approved these changes
Nov 21, 2023
oxisto
force-pushed
the
scope-hashcode
branch
from
13920f9 to
711e104
Compare
oxisto
added a commit
that referenced
this pull request
Nov 21, 2023
* Removed `parent` from `hashCode` of `Scope` This was causing MAJOR performance problems, since we are using the `hashCode` in the symbol resolver for caching. This had the effect that on deeply nested scopes, performance dropped quite largely. * Comparing scope in case of a cache hit to avoid collisions * Make control-flow sensitive DFG pass configurable by complexity This calculates a simple cylic complexity for functions and adds a configuration option to specify a max for the control-flow sensitive DFG pass. * Extracted configuration in a more generic pass-specific config * Added unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This calculates a simple cylic complexity for functions and adds a configuration option to specify a max for the control-flow sensitive DFG pass.