Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching symbols on symbol resolution #1334

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Caching symbols on symbol resolution #1334

merged 2 commits into from
Oct 18, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Oct 16, 2023

This PR caches symbol resolutions. This can can significantly speed up the resolution process.

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@maximiliankaul maximiliankaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Maybe provide some tests to make sure corner cases like variable shadowing work as expected?

@oxisto
Copy link
Member Author

oxisto commented Oct 18, 2023

I like this. Maybe provide some tests to make sure corner cases like variable shadowing work as expected?

Good idea. One caveat though: variable shadowing is not really supported even without caching :)

Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oxisto oxisto requested a review from KuechA as a code owner October 18, 2023 17:13
oxisto and others added 2 commits October 18, 2023 22:32
This PR caches symbol resolutions. This can can significantly speed up the resolution process.
…aryOperation` (#1333)

Support for `<<`, `>>` and `|` in `ValueEvaluator` and `BinaryOperation`
@oxisto oxisto enabled auto-merge (squash) October 18, 2023 20:37
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.8% 97.8% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit c40de13 into main Oct 18, 2023
3 checks passed
@oxisto oxisto deleted the cache-resolution branch October 18, 2023 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants