Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements of Go language frontend #1276

Merged
merged 14 commits into from
Sep 20, 2023
Merged

Improvements of Go language frontend #1276

merged 14 commits into from
Sep 20, 2023

Conversation

oxisto
Copy link
Member

@oxisto oxisto commented Aug 9, 2023 •
edited
Loading

Features

Fixes

  • Fixed scope handling of record declaration and methods
  • Fixed an issue that lead to the wrong package name when using module versions
  • Fixed issue where not all top-level declarations had an FQN

@oxisto oxisto changed the title go improvements Improvements of Go language frontend Aug 9, 2023
@oxisto oxisto added the go label Aug 9, 2023
@oxisto oxisto force-pushed the go-improvements branch 4 times, most recently from d4c4c01 to fab6e45 Compare August 10, 2023 18:32
@oxisto oxisto changed the base branch from main to move-type-resolver August 11, 2023 13:11
Base automatically changed from move-type-resolver to main August 14, 2023 09:41
@oxisto oxisto force-pushed the go-improvements branch 2 times, most recently from e86261c to 36e69fc Compare August 20, 2023 18:53
@oxisto oxisto force-pushed the go-improvements branch 18 times, most recently from 446f4a6 to 633348d Compare August 30, 2023 09:25
@oxisto oxisto requested a review from konradweiss as a code owner August 30, 2023 17:24
@oxisto oxisto force-pushed the go-improvements branch 2 times, most recently from 9134847 to 02d5646 Compare August 30, 2023 17:30
@oxisto oxisto requested a review from KuechA August 30, 2023 17:31
@oxisto oxisto force-pushed the go-improvements branch 2 times, most recently from b11312d to 348f46e Compare September 13, 2023 12:26
konradweiss
konradweiss requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@konradweiss konradweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some Doc and renaming it looks good to me, there are also two comments where I am not sure whether the problem should be solved in this PR or another one in which case I recommend marking the place with a TODO.

cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt Show resolved Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt Outdated Show resolved Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/ScopeManager.kt Outdated Show resolved Hide resolved
cpg-core/src/main/kotlin/de/fraunhofer/aisec/cpg/graph/declarations/FunctionDeclaration.kt Show resolved Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/golang/BuildConstraints.kt Show resolved Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/golang/GoUtils.kt Outdated Show resolved Hide resolved
cpg-language-go/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/GoEvaluationOrderGraphPass.kt Outdated Show resolved Hide resolved
@oxisto oxisto requested a review from konradweiss September 19, 2023 22:03
oxisto added 14 commits September 20, 2023 00:03
@sonarcloud
Copy link

sonarcloud bot commented Sep 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

86.3% 86.3% Coverage
0.0% 0.0% Duplication

@oxisto oxisto merged commit 6da9562 into main Sep 20, 2023
3 checks passed
@oxisto oxisto deleted the go-improvements branch September 20, 2023 12:27
@oxisto oxisto mentioned this pull request Sep 20, 2023
Closed
@KuechA KuechA mentioned this pull request May 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradweiss konradweiss konradweiss approved these changes

@KuechA KuechA Awaiting requested review from KuechA KuechA is a code owner

Assignees
No one assigned
Labels
go
Projects
None yet
Milestone
No milestone
3 participants
@oxisto @konradweiss @KuechA