alex fixed some stuff

Fraunhofer-AISEC · Oct 17, 2023 · c3a3fc0 · c3a3fc0
1 parent f05b33e
commit c3a3fc0
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 4 deletions.
diff --git a/...guage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt b/...guage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/StatementHandler.kt
@@ -310,8 +310,7 @@ class StatementHandler(frontend: PythonLanguageFrontend) :
     private fun handleArgument(node: PythonAST.arg) {
         val currentFunction = frontend.scopeManager.currentFunction
         val arg = newParameterDeclaration(name = node.arg, rawNode = node)
-        // frontend.scopeManager.addDeclaration(arg) // TODO why not?
-        currentFunction?.addParameter(arg)
+        frontend.scopeManager.addDeclaration(arg)
         // TODO type hints?
     }
 

diff --git a/...nguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/PythonAddDeclarationsPass.kt b/...nguage-python/src/main/kotlin/de/fraunhofer/aisec/cpg/passes/PythonAddDeclarationsPass.kt
@@ -124,8 +124,16 @@ class PythonAddDeclarationsPass(ctx: TranslationContext) : ComponentPass(ctx), N
 
             decl.isImplicit = true
 
-            decl.scope = scopeManager.currentScope // TODO why do we need this?
-            scopeManager.addDeclaration(decl)
+            if (decl is FieldDeclaration) {
+                decl.scope = scopeManager.currentRecord?.scope
+                scopeManager.currentRecord?.addField(decl)
+                scopeManager.withScope(scopeManager.currentRecord?.scope) {
+                    scopeManager.addDeclaration(decl)
+                }
+            } else {
+                decl.scope = scopeManager.currentScope // TODO why do we need this?
+                scopeManager.addDeclaration(decl)
+            }
             return decl
         } else {
             return null