Added test case for arithmetics

Fraunhofer-AISEC · Nov 30, 2023 · 58aee96 · 58aee96
1 parent bb3c623
commit 58aee96
Show file tree

Hide file tree

Showing 5 changed files with 47 additions and 2 deletions.
diff --git a/cpg-analysis/src/main/kotlin/de/fraunhofer/aisec/cpg/analysis/ValueEvaluator.kt b/cpg-analysis/src/main/kotlin/de/fraunhofer/aisec/cpg/analysis/ValueEvaluator.kt
@@ -56,7 +56,7 @@ open class ValueEvaluator(
      * Contains a reference to a function that gets called if the value cannot be resolved by the
      * standard behaviour.
      */
-    val cannotEvaluate: (Node?, ValueEvaluator) -> Any? = { node: Node?, _: ValueEvaluator ->
+    open val cannotEvaluate: (Node?, ValueEvaluator) -> Any? = { node: Node?, _: ValueEvaluator ->
         // end of the line, lets just keep the expression name
         if (node != null) {
             "{${node.name}}"
@@ -148,7 +148,7 @@ open class ValueEvaluator(
      * Note: this is both used by a [BinaryOperator] with basic arithmetic operations as well as
      * [AssignExpression], if [AssignExpression.isCompoundAssignment] is true.
      */
-    protected fun computeBinaryOpEffect(
+    protected open fun computeBinaryOpEffect(
         lhsValue: Any?,
         rhsValue: Any?,
         has: HasOperatorCode?,

diff --git a/cpg-language-python/build.gradle.kts b/cpg-language-python/build.gradle.kts
@@ -42,4 +42,7 @@ publishing {
 dependencies {
     // jep for python support
     api(libs.jep)
+
+    // to evaluate some test cases
+    testImplementation(project(":cpg-analysis"))
 }
diff --git a/...python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonValueEvaluator.java b/...python/src/main/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonValueEvaluator.java
@@ -0,0 +1,2 @@
+package de.fraunhofer.aisec.cpg.frontends.python;
+
diff --git a/...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonFrontendTest.kt b/...age-python/src/test/kotlin/de/fraunhofer/aisec/cpg/frontends/python/PythonFrontendTest.kt
@@ -27,6 +27,7 @@ package de.fraunhofer.aisec.cpg.frontends.python
 
 import de.fraunhofer.aisec.cpg.BaseTest
 import de.fraunhofer.aisec.cpg.TestUtils
+import de.fraunhofer.aisec.cpg.analysis.ValueEvaluator
 import de.fraunhofer.aisec.cpg.assertFullName
 import de.fraunhofer.aisec.cpg.assertLocalName
 import de.fraunhofer.aisec.cpg.graph.*
@@ -1082,4 +1083,42 @@ class PythonFrontendTest : BaseTest() {
             barCall.arguments.first().prevDFG.firstOrNull()
         )
     }
+
+    @Test
+    fun testArithmetics() {
+        val topLevel = Path.of("src", "test", "resources", "python")
+        val tu =
+            TestUtils.analyzeAndGetFirstTU(
+                listOf(topLevel.resolve("calc.py").toFile()),
+                topLevel,
+                true
+            ) {
+                it.registerLanguage<PythonLanguage>()
+            }
+        assertNotNull(tu)
+
+        val a = tu.refs["a"]
+        assertNotNull(a)
+
+        val result = a.evaluate(PythonValueEvaluator())
+        assertEquals(16.0, result)
+    }
+
+    class PythonValueEvaluator : ValueEvaluator() {
+        override fun computeBinaryOpEffect(
+            lhsValue: Any?,
+            rhsValue: Any?,
+            has: HasOperatorCode?,
+        ): Any? {
+            return if (has?.operatorCode == "**") {
+                when {
+                    lhsValue is Number && rhsValue is Number ->
+                        Math.pow(lhsValue.toDouble(), rhsValue.toDouble())
+                    else -> cannotEvaluate(has as Node, this)
+                }
+            } else {
+                super.computeBinaryOpEffect(lhsValue, rhsValue, has)
+            }
+        }
+    }
 }
diff --git a/cpg-language-python/src/test/resources/python/calc.py b/cpg-language-python/src/test/resources/python/calc.py
@@ -0,0 +1 @@
+a = (((3 - 1) / 2) * 4) ** 2
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		package de.fraunhofer.aisec.cpg.frontends.python;