Skip to content

Commit

Permalink
Addressed code review
Browse files Browse the repository at this point in the history
  • Loading branch information
oxisto committed Dec 2, 2024
1 parent 89176e8 commit 1456e75
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -591,9 +591,7 @@ open class SymbolResolver(ctx: TranslationContext) : ComponentPass(ctx) {
val records = possibleContainingTypes.mapNotNull { it.root.recordDeclaration }.toSet()
for (record in records) {
candidates.addAll(
ctx.scopeManager.lookupSymbolByName(record.name.fqn(symbol), record.language) {
it.language == record.language
}
ctx.scopeManager.lookupSymbolByName(record.name.fqn(symbol), record.language)
)
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,7 @@ class GoExtraPass(ctx: TranslationContext) : ComponentPass(ctx) {
// Try to see if we already know about this namespace somehow
val namespace =
scopeManager.lookupSymbolByNameOfNode(import).filter {
it is NamespaceDeclaration &&
it.path == import.importURL &&
it.language == import.language
it is NamespaceDeclaration && it.path == import.importURL
}

// If not, we can infer a namespace declaration, so we can bundle all inferred function
Expand Down

0 comments on commit 1456e75

Please sign in to comment.