Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine Future Kotlin Renovate PRs #891

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

CodingDepot
Copy link
Collaborator

This PR adds a new group to the renovate packageRules that matches the package prefixes org.jetbrains.kotlin:kotlin- and org.jetbrains.kotlin.plugin..

This aims to prevent situations such as with #889 and #890 or also #866 and #867, where two independent PRs are made to update the main Kotlin packages and the serialization plugin, but both PRs contain identical changes anyways.

@CodingDepot CodingDepot added nicetohave Not urgent, just a nice add-on that is worth discussing dependencies Pull requests that update a dependency file labels Jul 22, 2024
@CodingDepot CodingDepot requested a review from fwendland July 22, 2024 10:28
@CodingDepot CodingDepot self-assigned this Jul 22, 2024
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (332baee) to head (b5e8280).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #891   +/-   ##
=========================================
  Coverage     77.20%   77.20%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1882     1882           
  Branches        265      265           
=========================================
  Hits           1453     1453           
  Misses          308      308           
  Partials        121      121           
Flag Coverage Δ
unittests 77.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland
Copy link
Collaborator

The Kotlin monorepo from Renovate should actually combine all of them 🤔 (cf. https://docs.renovatebot.com/presets-monorepo/#monorepokotlin). All of these PRs are updating the same element of our gradle/libs.versions.toml, too. I'm guessing the plugins are released slightly delayed from the remaining Kotlin packages. I would still assume that Renovate combines them.

Can you check upstreams or issues/discussions before we start changing (a supposedly) working configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file nicetohave Not urgent, just a nice add-on that is worth discussing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants