Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the Portability Workflow from Failing Incorrectly #885

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

CodingDepot
Copy link
Collaborator

Currently, the last job of the portability workflow aggregates all failures of the previous matrix build.
However, the step Process Failures returns exit code 1 when it does not find any failures, causing the whole workflow to fail.

This PR only includes a continue-on-error flag on this step to ignore its output and rather only fail the workflow when any failing workflows were found.

@CodingDepot CodingDepot added bug Something isn't working CI labels Jul 3, 2024
@CodingDepot CodingDepot requested a review from fwendland July 3, 2024 08:32
@CodingDepot CodingDepot self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (efd0661) to head (a0a4f83).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #885   +/-   ##
=========================================
  Coverage     77.20%   77.20%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1882     1882           
  Branches        265      265           
=========================================
  Hits           1453     1453           
  Misses          308      308           
  Partials        121      121           
Flag Coverage Δ
unittests 77.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland fwendland merged commit 332baee into main Jul 18, 2024
6 checks passed
@fwendland fwendland deleted the rh/continue-upgrade-workflow branch July 18, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants