Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Path Issues in Codyze Tests #884

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Conversation

CodingDepot
Copy link
Collaborator

Some Codyze Tests still do not behave correctly when executed under certain conditions:

  • The VersionProviderTest does not correctly handle Windows paths that include spaces
  • The PluginTests fails with absolute Windows paths due to the semicolon in the path string

These Issues are fixed with this PR. I also plan to close #389 together with merging this issue.

@CodingDepot CodingDepot added the bug Something isn't working label Jul 3, 2024
@CodingDepot CodingDepot requested a review from fwendland July 3, 2024 08:12
@CodingDepot CodingDepot self-assigned this Jul 3, 2024
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (3868a52) to head (381845e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #884   +/-   ##
=========================================
  Coverage     77.20%   77.20%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1882     1882           
  Branches        265      265           
=========================================
  Hits           1453     1453           
  Misses          308      308           
  Partials        121      121           
Flag Coverage Δ
unittests 77.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

fwendland and others added 4 commits July 18, 2024 10:55
@fwendland fwendland merged commit 83170da into main Sep 17, 2024
6 checks passed
@fwendland fwendland deleted the rh/windows-path-issues branch September 17, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mark tests do not handle spaces in filepath
2 participants