Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sporadic problems in test due to misaligned JUnit version #862

Merged
merged 1 commit into from
May 13, 2024

Conversation

fwendland
Copy link
Collaborator

Sometimes the tests fail due to AbstractMethod errors. The cause seems to be the use of JUnit params in a given version and using JUnit platform in another. This change:

  • alignes JUnit version through the use of a platform declaration
  • lets individual package version be aligned through the platform

Sometimes the tests fail due to AbstractMethod errors. The cause
seems to be the use of JUnit params in a given version and using
JUnit platform in another. This change:
* alignes JUnit version through the use of a platform declaration
* lets individual package version be aligned through the platform
@fwendland fwendland added bug Something isn't working dependencies Pull requests that update a dependency file labels May 10, 2024
@fwendland fwendland self-assigned this May 10, 2024
@fwendland fwendland requested a review from CodingDepot May 10, 2024 09:13
Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.20%. Comparing base (612e80d) to head (30a24c6).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #862   +/-   ##
=========================================
  Coverage     77.20%   77.20%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1882     1882           
  Branches        265      265           
=========================================
  Hits           1453     1453           
  Misses          308      308           
  Partials        121      121           
Flag Coverage Δ
unittests 77.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland fwendland merged commit 14a7280 into main May 13, 2024
6 checks passed
@fwendland fwendland deleted the fw/fix-junit-version-alignment branch May 13, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants