Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows Paths in Coko Tests #853

Merged
merged 8 commits into from
May 3, 2024
Merged

Conversation

CodingDepot
Copy link
Collaborator

Complementing #836, this PR fixes more cases of the Path constructor being used on absolute windows paths.

Additionally, the import statement in Coko source code examples relies on invariant Path separators (forward slashes), which is now also properly applied.

@CodingDepot CodingDepot added the bug Something isn't working label Apr 17, 2024
@CodingDepot CodingDepot requested a review from fwendland April 17, 2024 09:32
@CodingDepot CodingDepot self-assigned this Apr 17, 2024
Copy link

codecov bot commented Apr 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.04%. Comparing base (890f615) to head (d827da2).
Report is 1 commits behind head on main.

❗ Current head d827da2 differs from pull request most recent head 99db8bc. Consider uploading reports for the commit 99db8bc to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #853   +/-   ##
=========================================
  Coverage     77.04%   77.04%           
  Complexity      250      250           
=========================================
  Files            59       59           
  Lines          1895     1895           
  Branches        265      265           
=========================================
  Hits           1460     1460           
  Misses          314      314           
  Partials        121      121           
Flag Coverage Δ
unittests 77.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland fwendland merged commit e8d26b3 into main May 3, 2024
4 checks passed
@fwendland fwendland deleted the rh/fix-windows-coko-tests branch May 3, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants