Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upgrade workflow #837

Merged
merged 12 commits into from
Apr 5, 2024
Merged

Fix upgrade workflow #837

merged 12 commits into from
Apr 5, 2024

Conversation

CodingDepot
Copy link
Collaborator

Semi-recent restructurings in the project repository broke the upgrade workflow that checks the build on different OS with different Java versions.

This PR fixes the workflow and removes the masking of negative results on job-level so that such breaks can be easier found in the future.

This PR also changes the workflow slightly in that the unit tests are now executed when building.

@CodingDepot CodingDepot added bug Something isn't working CI labels Apr 3, 2024
@CodingDepot CodingDepot requested a review from fwendland April 3, 2024 10:30
@CodingDepot CodingDepot self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.67%. Comparing base (0cd0f2e) to head (891cbd7).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #837   +/-   ##
=========================================
  Coverage     81.67%   81.67%           
  Complexity      178      178           
=========================================
  Files            49       49           
  Lines          1370     1370           
  Branches        189      189           
=========================================
  Hits           1119     1119           
  Misses          158      158           
  Partials         93       93           
Flag Coverage Δ
unittests 81.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland fwendland force-pushed the rh/fix-upgrade-workflow branch 2 times, most recently from 7061fca to 968cde0 Compare April 5, 2024 10:49
@fwendland fwendland force-pushed the rh/fix-upgrade-workflow branch from 968cde0 to 891cbd7 Compare April 5, 2024 11:05
@fwendland fwendland merged commit d107805 into main Apr 5, 2024
10 of 13 checks passed
@fwendland fwendland deleted the rh/fix-upgrade-workflow branch April 5, 2024 11:15
fwendland added a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Florian Wendland <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants