Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Plugin Support #794

Merged
merged 92 commits into from
Apr 15, 2024
Merged

Add Plugin Support #794

merged 92 commits into from
Apr 15, 2024

Conversation

CodingDepot
Copy link
Collaborator

@CodingDepot CodingDepot commented Dec 13, 2023

This PR adds Plugins to Codyze.

Plugins utilize the functionality of other analysis tools and combine them with Codyze.
Each Plugin registers its own subcommand, which takes arguments such as the analysis target and more optional parameters.

To smoothly integrate the results of the plugins, this PR also introduces the Aggregator class.
This class stores SARIF runs and outputs one combined SARIF run, marking each of the used plugins as an extension to codyze.

At this moment, only the PMD and FindSecBugs (SpotBugs) tools are supported as Plugins with limited rulesets.
The number of plugins and rules can be expanded in future pull requests.

Future functionality could also include reading a SARIF file produced by an external tool and loading it into the Codyze SARIF file.

@CodingDepot CodingDepot added the enhancement New feature or request label Dec 13, 2023
@CodingDepot CodingDepot self-assigned this Dec 13, 2023
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: Patch coverage is 86.08696% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 77.04%. Comparing base (08de9bd) to head (7028ee0).
Report is 1 commits behind head on main.

Files Patch % Lines
...r/aisec/codyze/core/output/aggregator/Aggregate.kt 88.50% 1 Missing and 9 partials ⚠️
...ofer/aisec/codyze/core/output/aggregator/Parser.kt 68.42% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #794      +/-   ##
============================================
- Coverage     82.39%   77.04%   -5.35%     
- Complexity      179      250      +71     
============================================
  Files            49       59      +10     
  Lines          1363     1895     +532     
  Branches        184      265      +81     
============================================
+ Hits           1123     1460     +337     
- Misses          157      314     +157     
- Partials         83      121      +38     
Flag Coverage Δ
unittests 77.04% <86.08%> (-5.35%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fwendland fwendland merged commit 386a800 into main Apr 15, 2024
6 checks passed
@fwendland fwendland deleted the rh/aggregator branch April 15, 2024 13:28
fwendland added a commit that referenced this pull request Apr 15, 2024
Co-authored-by: Florian Wendland <[email protected]>
@CodingDepot CodingDepot mentioned this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants