Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection of various fixes #49

Merged
merged 11 commits into from
Aug 11, 2022
Merged

Collection of various fixes #49

merged 11 commits into from
Aug 11, 2022

Conversation

lukasauer
Copy link
Member

This pull request contains a collection of multiple fixes. Notable changes include the following.

  • Fixed support for 128-bit masks. This change necessitates the addition of a new column (fault_mask_upper) to the HDF5 file format for storing the upper 64-bit of the fault mask.
  • Allow single integer values in the fault configuration to be directly accepted without nesting them in a list.
  • Fix another occurrence of large integer register values being cast to floats (see also Specify explicit register data type to avoid integer conversion errors #41 and Use explicit data types with pandas #42)
  • Validate the HDF5-file argument by checking if its parent directory exists. Previously, ARCHIE would silently fail if it could not create the HDF5 file.

lukasauer added 11 commits August 2, 2022 15:30
@lukasauer
Fix support for 128-bit fault masks
afe99ca 
This adds a new column, fault_mask_upper, to the HDF5 file format to be
able to store the 128-bit mask value. It stores the upper 64-bit of the
column fault_mask.
@lukasauer
Accept integers in fault configuration directly without list
6fa523f
@lukasauer
Fix unintended cast of large integer registers to floats
0d9ebc2 
The call to pandas.concat in write_output_wrt_goldenrun() causes large
integer registers values to be cast to floats. Since the register values
do not have to be deduplicated, do not process them with
write_output_wrt_goldenrun().

See also Fraunhofer-AISEC#41 and Fraunhofer-AISEC#42
@lukasauer
Fix memorydump function signatures in faultplugin
2cddbb9 
The functions for reading memory dumps do not have a return value.
Adjust their function signatures accordingly.
@lukasauer
faultclass: remove unused function
08b8cc9
@lukasauer
Make get_system_ram() function more robust
95817df 
In some situations, the  get_system_ram() function is not able to read
from the subprocess. Change the function to use communicate() instead of
poll() to read from the subprocess. This fixes this issue.
@lukasauer
QEMU configuration must be terminated by a new line
6044cea
@lukasauer
Unlock end point depending on state of start point not its hit counter
dcc4427
@lukasauer
Validate HDF5-file argument by ensuring parent exists
e75304c
@lukasauer
Remove unused submodules
fd3d9fb
@lukasauer
Remove old artifact
9260c8d
@lukasauer lukasauer merged commit 0d23ca9 into Fraunhofer-AISEC:master Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aewag aewag aewag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukasauer @aewag